Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: reqrep prefix corrected #101

Merged
merged 5 commits into from
Oct 11, 2023
Merged

Fix: reqrep prefix corrected #101

merged 5 commits into from
Oct 11, 2023

Conversation

ch4r10t33r
Copy link
Member

Description

Corrected the protocol prefix used in ReqResp protocol

Types of changes

What types of changes does your code introduce?

  • [x ] Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Other (please describe):

Further comments (optional)

@0xSulpiride
Copy link
Member

0xSulpiride commented Oct 11, 2023 •
edited
Loading

I will include fix of another issue related to protocolId here @ch4r10t33r

I need to delete ssz_snappy suffix

@ch4r10t33r ch4r10t33r added the bug Something isn't working label Oct 11, 2023
0xSulpiride
0xSulpiride approved these changes Oct 11, 2023
View reviewed changes
Copy link
Member

@0xSulpiride 0xSulpiride left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed some typos

DEFAULT_PROTOCOL_PREFIX should be account_abstraction/req

Updated goerli's mempool info

@ch4r10t33r ch4r10t33r changed the title Fix reqrep Fix: reqrep prefix corrected Oct 11, 2023
@0xSulpiride 0xSulpiride merged commit 0472004 into master Oct 11, 2023
2 of 4 checks passed
@0xSulpiride 0xSulpiride deleted the fix_reqrep branch October 11, 2023 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xSulpiride 0xSulpiride 0xSulpiride approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ch4r10t33r @0xSulpiride