Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: userops ttl #100

Merged
merged 7 commits into from
Oct 12, 2023
Merged

feat: userops ttl #100

merged 7 commits into from
Oct 12, 2023

Conversation

0xSulpiride
Copy link
Member

@0xSulpiride 0xSulpiride commented Oct 10, 2023 •
edited
Loading

Description

  • added new config param useropsTTL which sets ttl on userops in seconds. Default value is 300
  • After 300 seconds new userops with the same nonce and sender will replace existing userops without increasing gas fees. But if there's no incoming userops, the existing userops are not deleted from mempool after 300 seconds

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Other (please describe):

Further comments (optional)

ch4r10t33r
ch4r10t33r requested changes Oct 10, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
packages/executor/src/config.ts Outdated Show resolved Hide resolved
ch4r10t33r
ch4r10t33r approved these changes Oct 10, 2023
View reviewed changes
Copy link
Member

@ch4r10t33r ch4r10t33r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ch4r10t33r ch4r10t33r added the enhancement New feature or request label Oct 11, 2023
@0xSulpiride 0xSulpiride merged commit 4502750 into master Oct 12, 2023
3 of 4 checks passed
@0xSulpiride 0xSulpiride deleted the userop-ttl branch October 12, 2023 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ch4r10t33r ch4r10t33r ch4r10t33r approved these changes

@arddluma arddluma Awaiting requested review from arddluma

Assignees
No one assigned
Labels
enhancement New feature or request
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0xSulpiride @ch4r10t33r