Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ft: adding cron jobs to increase cache hit ratio for oracle data #157

Merged
merged 3 commits into from
Dec 18, 2024
Merged

ft: adding cron jobs to increase cache hit ratio for oracle data #157

merged 3 commits into from
Dec 18, 2024
+143 −21

Conversation

nikhilkumar1612
Copy link
Contributor

Description

  • Added cron jobs to update cache for native and erc20 oracle data

Types of changes

What types of changes does your code introduce?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Other (please describe):

Further comments (optional)

  • test result after cron run for pm_getERC20TokenQuotes rpc method for 43 tokens.
Screenshot 2024-12-18 at 2 58 39 PM

@linear Linear
Copy link

linear bot commented Dec 18, 2024

PRO-2929 housekeeper scripts on arka

@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Dec 18, 2024 •
edited
Loading

Deploying arka with  Cloudflare Pages  Cloudflare Pages

Latest commit: b9d3373
Status: ✅  Deploy successful!
Preview URL: https://b72d69dd.arka-3qg.pages.dev
Branch Preview URL: https://pro-2929.arka-3qg.pages.dev

View logs

ch4r10t33r
ch4r10t33r approved these changes Dec 18, 2024
View reviewed changes
Copy link
Member

@ch4r10t33r ch4r10t33r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @vignesha22 Pls note that you might have to include these changes in your coingecko PR as well.

ch4r10t33r
ch4r10t33r approved these changes Dec 18, 2024
View reviewed changes
Copy link
Member

@ch4r10t33r ch4r10t33r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have to ensure the cringing gets triggered only and immediately after the cache has expired. Otherwise it won't be effective. LGTM

@nikhilkumar1612 nikhilkumar1612 merged commit 18ec374 into master Dec 18, 2024
4 checks passed
@nikhilkumar1612 nikhilkumar1612 deleted the PRO-2929 branch December 18, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ch4r10t33r ch4r10t33r ch4r10t33r approved these changes

@vignesha22 vignesha22 Awaiting requested review from vignesha22

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nikhilkumar1612 @ch4r10t33r