Pro 2758 #145
Merged
Pro 2758 #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikhilkumar1612
commented
Oct 8, 2024
| @@ -90,7 +96,10 @@ const configPlugin: FastifyPluginAsync = async (server) => { | |||
| EP7_TOKEN_VGL: process.env.EP7_TOKEN_VGL ?? '90000', | |||
| EP7_TOKEN_PGL: process.env.EP7_TOKEN_PGL ?? '150000', | |||
| EPV_06: process.env.EPV_06?.split(',') ?? ['0x5FF137D4b0FDCD49DcA30c7CF57E578a026d2789'], | |||
| EPV_07: process.env.EPV_07?.split(',') ?? ['0x0000000071727De22E5E9d8BAf0edAc6f37da032'] | |||
| EPV_07: process.env.EPV_07?.split(',') ?? ['0x0000000071727De22E5E9d8BAf0edAc6f37da032'], | |||
| DELETE_KEY_RECOVER_WINDOW: parseInt(process.env.DELETE_KEY_RECOVER_WINDOW || '7'), | |||
There was a problem hiding this comment.
@ch4r10t33r using 7 days because only 7-30 days values are allowed for scheduled deletion.
Deploying arka with
|
| Latest commit: |
1a7179d
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://40e67923.arka-3qg.pages.dev |
| Branch Preview URL: | https://pro-2758.arka-3qg.pages.dev |
vignesha22
requested changes
Oct 14, 2024
| MNEMONIC: mnemonic | ||
| }), | ||
| }); | ||
|
|
There was a problem hiding this comment.
We need to also create a record on the connected db since the sponsorship olivies are handled by that so even in unsafeMode as false create one record on was secrets as above and also include database record creation for the same which also includes addition of policy record by default for the same apiKey
There was a problem hiding this comment.
@vignesha22 does this mean we have to delete the record also on /deleteKey endpoint ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Types of changes
What types of changes does your code introduce?
Further comments (optional)