Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pro 2579 cron changes #125

Merged
merged 3 commits into from
Aug 20, 2024
Merged

Pro 2579 cron changes #125

merged 3 commits into from
Aug 20, 2024

Conversation

nikhilkumar1612
Copy link
Contributor

Description

  • New env variable for price update cron job(PRICE_UPDATE_CRON_EXP).
  • adding support safe mode for price update cron job.
  • adding contract address for pimlico erc20 paymaster on flare.

Types of changes

What types of changes does your code introduce?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Other (please describe):

Further comments (optional)

@linear Linear
Copy link

linear bot commented Aug 16, 2024

PRO-2579 Oracle and Token Paymaster Deployment on Flare

@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Aug 19, 2024 •
edited
Loading

Deploying arka with  Cloudflare Pages  Cloudflare Pages

Latest commit: 8735cf1
Status: ✅  Deploy successful!
Preview URL: https://54620e6e.arka-3qg.pages.dev
Branch Preview URL: https://pro-2579-cron-changes.arka-3qg.pages.dev

View logs

nikhilkumar1612
nikhilkumar1612 commented Aug 19, 2024
View reviewed changes
backend/src/server.ts
);
const secrets = JSON.parse(AWSresponse.SecretString ?? '{}');
configData = {
coingeckoApiUrl: secrets["COINGECKO_API_URL"],
Copy link
Contributor Author

@nikhilkumar1612 nikhilkumar1612 Aug 19, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i need someone to verify if the keys which i have used are valid on secrets manager:
COINGECKO_API_URL, COINGECKO_IDS, CUSTOM_CHAINLINK_DEPLOYED, DEPLOYED_ERC20_PAYMASTERS, PYTH_MAINNET_CHAINIDS, PYTH_MAINNET_URL, PYTH_TESTNET_CHAINIDS, PYTH_TESTNET_URL

cc: @kanthgithub @ch4r10t33r @sarthakprp

vignesha22
vignesha22 approved these changes Aug 20, 2024
View reviewed changes
Copy link
Contributor

@vignesha22 vignesha22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nikhilkumar1612 nikhilkumar1612 merged commit 9cce3fa into master Aug 20, 2024
4 checks passed
@nikhilkumar1612 nikhilkumar1612 deleted the PRO-2579-Cron-changes branch August 20, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vignesha22 vignesha22 vignesha22 approved these changes

@kanthgithub kanthgithub kanthgithub approved these changes

@ch4r10t33r ch4r10t33r Awaiting requested review from ch4r10t33r

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nikhilkumar1612 @kanthgithub @vignesha22