Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sponsorship Policy API functions and Integrate with paymaster data generation endpoint #111

Merged
merged 43 commits into from
Jun 26, 2024

Conversation

kanthgithub
Copy link
Contributor

@kanthgithub kanthgithub commented Jun 17, 2024

Description

  • Migrate the Database from sqllite to postgres
  • refactor backend code to use sequelize (orm) framework
  • add sequelize models, migration scripts for all existing tables (config, api_key)
  • refactor the routes, add data repository typescript functions for db calls
  • remove native sql executions
  • SponsorshipPolicy sequelize models, migration scripts, repository functions
  • new route with API functions for CRUD operations on Sponsorship Policy
  • admin_frontend, frontend repository changes needed to accomodate/decouple the database column references in UI
  • docker file changes for new configuration variables of postgres database
  • new docker file in backend to run postgres on local docker and usage guide for testing on local machine
  • enable, disable Sponsorship Policies
  • validations during create/update policies
  • If the mode is sponsor then validate the userOp data with constraints built from sponsorship policy details

Sponsorship Policy Management

Arka needs to have the ability to setup sponsorship policies, these will be offered as a backend API within Arka and this can be consumed by our developer dashboard.

Types of changes

  • Design Doc

  • implementation (feature)

  • [ X] New feature (non-breaking change which adds functionality)

  • Documentation Update

…ates for APIKey entity references in backend and frontend components
…es for sponsorship_policy tables and api_keys association
Copy link

linear bot commented Jun 17, 2024

@kanthgithub kanthgithub requested a review from vignesha22 June 17, 2024 14:24
@kanthgithub kanthgithub self-assigned this Jun 17, 2024
@kanthgithub kanthgithub added the enhancement New feature or request label Jun 17, 2024
Copy link

cloudflare-workers-and-pages bot commented Jun 18, 2024

Deploying arka with  Cloudflare Pages  Cloudflare Pages

Latest commit: 024696e
Status: ✅  Deploy successful!
Preview URL: https://c06b10c6.arka-3qg.pages.dev
Branch Preview URL: https://pro-2455-sponsorship-policy.arka-3qg.pages.dev

View logs

Copy link

gitguardian bot commented Jun 20, 2024

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
11777939 Triggered Generic High Entropy Secret 6c8ad04 docker-compose.yml View secret
11777939 Triggered Generic High Entropy Secret 5072ea1 docker-compose.yml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@kanthgithub kanthgithub marked this pull request as ready for review June 20, 2024 19:19
@kanthgithub kanthgithub changed the base branch from PRO-2395-Sponsorship-Policies to master June 21, 2024 04:11
@kanthgithub kanthgithub changed the base branch from master to PRO-2395-Sponsorship-Policies June 21, 2024 04:12
@kanthgithub kanthgithub changed the base branch from PRO-2395-Sponsorship-Policies to master June 24, 2024 10:49
@kanthgithub kanthgithub requested a review from ch4r10t33r June 24, 2024 19:52
…tgres database docker file setup to project root directory
Copy link
Contributor

@vignesha22 vignesha22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kanthgithub kanthgithub merged commit 2d265c8 into master Jun 26, 2024
2 of 4 checks passed
@kanthgithub kanthgithub deleted the PRO-2455-Sponsorship-Policy-Integration branch June 26, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

3 participants