Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: PRO-2399 update defaultNetworks config for admin-frontend #108

Merged
merged 3 commits into from
Jun 11, 2024

Conversation

kanthgithub
Copy link
Contributor

Description

  • admin-frontend refers to default-network configuration json when the supported-networks is not specified by user/sponsor on admin UI while adding/updating APIKey
  • the default-config must have the entrypoint addresses configured for all the chainIds / supported networks

Types of changes

  • backend service has a default network config to be used as default supportedNetworks for the APIKey/Sponsor Address

  • this includes the EntryPointContract address for each chain/network

  • the admin-frontend should have the same configuration as default settings

  • [X ] Bugfix (non-breaking change which fixes an issue)

@kanthgithub kanthgithub self-assigned this Jun 8, 2024
Copy link

linear bot commented Jun 8, 2024

@kanthgithub kanthgithub requested a review from vignesha22 June 8, 2024 16:27
Copy link

cloudflare-workers-and-pages bot commented Jun 8, 2024

Deploying arka with  Cloudflare Pages  Cloudflare Pages

Latest commit: ca1390a
Status: ✅  Deploy successful!
Preview URL: https://4d1b334c.arka-3qg.pages.dev
Branch Preview URL: https://fix-pro-2399-default-network.arka-3qg.pages.dev

View logs

@kanthgithub kanthgithub requested a review from arddluma June 11, 2024 03:57
Copy link
Contributor

@vignesha22 vignesha22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kanthgithub kanthgithub merged commit b3bf21c into master Jun 11, 2024
4 checks passed
@kanthgithub kanthgithub deleted the fix/PRO-2399-default-network-updates branch June 11, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants