Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed and Enabled Kaia mainnet #1767

Merged
merged 4 commits into from
Dec 6, 2024

Conversation

praveen-kaia
Copy link
Contributor

Add New Chain 8217-1001

Thanks for your pull request to add a new support in Sourcify.

If you haven't done so, please follow the instructions on how to request chain support in docs.

Please check the following items before submitting your pull request for a speedy review.

Checklist

  • The branch is named as add-chain-<chainId>.
  • I haven't modified the chains.json file directly.
  • In sourcify-chains.json file
    • I've set supported: true.
    • I haven't added an rpc field but the one in chains.json is used (if not, please explain why).
  • I've added a test in chain-tests.js file.
  • test-new-chain test in Circle CI is passing.

@kuzdogan
Copy link
Member

kuzdogan commented Dec 4, 2024

Tests failing because of RPCs. Will check after #1768

@kuzdogan
Copy link
Member

kuzdogan commented Dec 4, 2024

Tests are still failing.

@praveen-kaia
Copy link
Contributor Author

@kuzdogan , Fixed the issue. Can you please the PR now. Thanks for your time.

@kuzdogan kuzdogan merged commit 438721a into ethereum:staging Dec 6, 2024
4 checks passed
@kuzdogan
Copy link
Member

kuzdogan commented Dec 6, 2024

Thanks! Looking good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Sprint - Done
Development

Successfully merging this pull request may close these issues.

2 participants