-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sort pre-0.4.0 versions properly #20
base: gh-pages
Are you sure you want to change the base?
Conversation
@cameel while this is definitely not a pressing issue, perhaps we may want to get this done? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure there's any point in doing this given that there are no nightlies earlier than 0.4.10 in the repo. Or do we want to restore them?
This comment has been minimized.
This comment has been minimized.
They definitely existed, hence the PR.
Hmm, I think we should have the proper history, especially as we now serve this off-github. |
OK then. Here's a PR that restores them: #103. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Alex Beregszaszi <[email protected]> Co-authored-by: Kamil Śliwak <[email protected]>
"path": "solc-emscripten-wasm32-v0.3.6-workaround+commit.3fc68da5.js", | ||
"version": "0.3.6", | ||
"prerelease": "workaround", | ||
"build": "commit.3fc68da5", | ||
"longVersion": "0.3.6-workaround-workaround+commit.3fc68da5", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cameel although the tests passed, I noticed one weird case here though. So please do not approve it yet. It seems that the symlink is being created with the -workaround
and then the longVersion
get it doubled.
This fixes the sorting order for <0.4.0 -- which was changed by #8.