Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the curve_name from the fields API #61

Merged
merged 2 commits into from
Mar 7, 2019

Conversation

Bhargavasomu
Copy link
Contributor

What was wrong?

In the __init__.py of the fields API the classes have been declared using type. This has to be replaced with the actual class definitions.

How was it fixed?

Replace the type with class in the __init__.py.

Cute Animal Picture

put a cute animal picture link inside the parentheses

@Bhargavasomu
Copy link
Contributor Author

@pipermerriam @carver @ChihChengLiang I forgot to push this as part of PR #41. Please review and merge. Thankyou.

@Bhargavasomu Bhargavasomu reopened this Mar 7, 2019
@Bhargavasomu Bhargavasomu changed the title Refactor v2 Remove the curve_name from the fields API Mar 7, 2019
Copy link
Contributor

@ChihChengLiang ChihChengLiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@pipermerriam pipermerriam merged commit b83b807 into ethereum:master Mar 7, 2019
@Bhargavasomu Bhargavasomu deleted the refactor_v2 branch March 12, 2019 03:37
pacrob pushed a commit to pacrob/py_ecc that referenced this pull request Oct 29, 2023
* Add breaking change type to newsfragment

* Move breaking-change -> breaking
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants