Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put py38 support back in; reserve for major release cycle. #151

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,12 @@ jobs:
environment:
TOXENV: docs

py38-core:
<<: *common
docker:
- image: cimg/python:3.8
environment:
TOXENV: py38-core
py39-core:
<<: *common
docker:
Expand Down Expand Up @@ -149,6 +155,12 @@ jobs:
environment:
TOXENV: py313-core

py38-lint:
<<: *common
docker:
- image: cimg/python:3.8
environment:
TOXENV: py38-lint
py39-lint:
<<: *common
docker:
Expand Down Expand Up @@ -180,6 +192,12 @@ jobs:
environment:
TOXENV: py313-lint

py38-wheel:
<<: *common
docker:
- image: cimg/python:3.8
environment:
TOXENV: py38-wheel
py39-wheel:
<<: *common
docker:
Expand Down Expand Up @@ -250,6 +268,12 @@ jobs:
- <<: *run-tox-step
- <<: *save-cache-step

py38-bls:
<<: *common
docker:
- image: cimg/python:3.8
environment:
TOXENV: py38-bls
py39-bls:
<<: *common
docker:
Expand Down Expand Up @@ -283,16 +307,19 @@ jobs:

define: &all_jobs
- docs
- py38-core
- py39-core
- py310-core
- py311-core
- py312-core
- py313-core
- py38-lint
- py39-lint
- py310-lint
- py311-lint
- py312-lint
- py313-lint
- py38-wheel
- py39-wheel
- py310-wheel
- py311-wheel
Expand All @@ -301,6 +328,7 @@ define: &all_jobs
- py311-windows-wheel
- py312-windows-wheel
- py313-windows-wheel
- py38-bls
- py39-bls
- py310-bls
- py311-bls
Expand Down
2 changes: 1 addition & 1 deletion .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ repos:
rev: v3.15.0
hooks:
- id: pyupgrade
args: [--py39-plus]
args: [--py38-plus]
- repo: https://github.com/psf/black
rev: 23.9.1
hooks:
Expand Down
2 changes: 1 addition & 1 deletion newsfragments/148.internal.rst
Original file line number Diff line number Diff line change
@@ -1 +1 @@
Drop python 3.8 and add 3.13 in CI and lib metadata
Add support for 3.13 in CI and lib metadata.
3 changes: 2 additions & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@
"eth-utils>=2.0.0",
"cached-property>=1.5.1",
],
python_requires=">=3.9, <4",
python_requires=">=3.8, <4",
extras_require=extras_require,
py_modules=["py_ecc"],
license="MIT",
Expand All @@ -66,6 +66,7 @@
"License :: OSI Approved :: MIT License",
"Natural Language :: English",
"Programming Language :: Python :: 3",
"Programming Language :: Python :: 3.8",
"Programming Language :: Python :: 3.9",
"Programming Language :: Python :: 3.10",
"Programming Language :: Python :: 3.11",
Expand Down
13 changes: 7 additions & 6 deletions tox.ini
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
[tox]
envlist=
py{39,310,311,312,313}-core
py{39,310,311,312,313}-lint
py{39,310,311,312,313}-wheel
py{39,310,311,312,313}-bls
py{38,39,310,311,312,313}-core
py{38,39,310,311,312,313}-lint
py{38,39,310,311,312,313}-wheel
py{38,39,310,311,312,313}-bls
windows-wheel
docs

Expand All @@ -27,6 +27,7 @@ commands=
basepython=
docs: python
windows-wheel: python
py38: python3.8
py39: python3.9
py310: python3.10
py311: python3.11
Expand All @@ -37,14 +38,14 @@ extras=
docs
allowlist_externals=make,pre-commit

[testenv:py{39,310,311,312,313}-lint]
[testenv:py{38,39,310,311,312,313}-lint]
deps=pre-commit
extras=dev
commands=
pre-commit install
pre-commit run --all-files --show-diff-on-failure

[testenv:py{39,310,311,312,313}-wheel]
[testenv:py{38,39,310,311,312,313}-wheel]
deps=
wheel
build[virtualenv]
Expand Down