This repository has been archived by the owner on Sep 5, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@luclu, thanks for your PR! By analyzing the history of the files in this pull request, we identified @hiddentao to be a potential reviewer. |
This reverts commit 9926067.
10 tasks
- node_modules as yarn has already a great caching - .cache as this can cause problems with missing global npm modules and changed .travis config - .electron as this is already more efficently cached by travis cluster
- was missing on osx - travis has its internal version of yarn on linux
Merged
superseeded |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs rebase on Taylor's merged PR
fixes #1182
Currently splits the builds in (1: sudo trusty) linux + win and (2: osx) mac.
Outstanding TODO:
addons: apt:
, travis whitelist "PRs":copy-app-folder-files
: 1.48 min instead of 3.91 s (trusty)download-signatures
: errored after 1.52 min instead of 4.49 s (trusty)download-signatures
as the command does not finish in time for the copy stage when using travis, simpler alternative: use sync instead of async but will increase build-time by 3-7stravis wait
-wrapped command travis_wait discards wrapped command output travis-ci/travis-ci#5716