-
Notifications
You must be signed in to change notification settings - Fork 380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
engine: extract execution requests from payload #587
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome, thank you!
I think we are missing a change to engine_getPayloadV4
as well
the result object also needs the execution_requests
, either in the payload type, or as a sibling property like you did for engine_newPayloadV4
#577 takes the approach to just include the |
@ralexstokes updated |
@ralexstokes when are we going to make decision around #577? also, seems like it needs to be rebased on top of this PR to extract requests from |
@rkrasiuk hopefully on ACDC tomorrow! (ethereum/pm#1154) although what I meant is that if we go with the approach in #577 we will want to change this PR to reflect that, instead of changing #577 if we keep this PR like it is now, we can remove |
closing in favor of #591 |
Description
Follow up on ethereum/consensus-specs#3875:
ExecutionRequestsV1
ExecutionPayloadV4
requests
field toExecutionPayloadBodyV2
executionRequests
parameter toengine_newPayloadV4
requests
field toengine_getPayloadV4
engine_getPayloadBodiesByHashV1
andengine_getPayloadBodiesByRangeV2