-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update proof of stake section (wiki migration) #6157
Conversation
Gatsby Cloud Build Reportethereum-org-website-dev 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 16m PerformanceLighthouse report
|
### The beacon chain {#the-beacon-chain} | ||
|
||
When Ethereum replaces proof-of-work with proof-of-stake, there will be the added complexity of [shard chains](/upgrades/shard-chains/). These are separate blockchains that will need validators to process transactions and create new blocks. The plan is to have 64 shard chains, with each having a shared understanding of the state of the network. As a result, extra coordination is necessary and will be done by [the beacon chain](/upgrades/beacon-chain/). | ||
- better energy efficiency – there is no need to use lots of energy on PoW computations |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we use proof-of-work / proof-of-stake over the acronym as per the style guide
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm I had to fix a bunch of these and realised that this maybe isn't actually clear:
We stick to spelling out full terms (proof-of-stake) over acronyms (PoS) to avoid the potential cognitive overhead it causes.
See this section of the Google Technical Writing Guide for the reasoning we used to inform this choice.
src/content/developers/docs/consensus-mechanisms/pos/gasper/index.md
Outdated
Show resolved
Hide resolved
src/content/developers/docs/consensus-mechanisms/pos/weak-subjectivity/index.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @jmcook1186, this looks great ❤️❤️. Left some high-level comments but will try to do a full review by tomorrow.
src/content/developers/docs/consensus-mechanisms/pos/gasper/index.md
Outdated
Show resolved
Hide resolved
@@ -0,0 +1,42 @@ | |||
--- | |||
title: Gasper | |||
description: An explanation of the Gasper PoS mechanism. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
description: An explanation of the Gasper PoS mechanism. | |
description: An explanation of the Gasper proof-of-stake mechanism. |
src/content/developers/docs/consensus-mechanisms/pos/gasper/index.md
Outdated
Show resolved
Hide resolved
src/content/developers/docs/consensus-mechanisms/pos/gasper/index.md
Outdated
Show resolved
Hide resolved
src/content/developers/docs/consensus-mechanisms/pos/weak-subjectivity/index.md
Outdated
Show resolved
Hide resolved
src/content/developers/docs/consensus-mechanisms/pos/weak-subjectivity/index.md
Outdated
Show resolved
Hide resolved
src/content/developers/docs/consensus-mechanisms/pos/weak-subjectivity/index.md
Outdated
Show resolved
Hide resolved
src/content/developers/docs/consensus-mechanisms/pos/weak-subjectivity/index.md
Outdated
Show resolved
Hide resolved
src/content/developers/docs/consensus-mechanisms/pos/gasper/index.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great @jmcook1186 (And I actually learned a bunch, thanks 😀)! I've committed some formatting changes but nothing major.
Left two comments for you to consider but not blocking this PR; we can definitely merge this and work on those later.
I also think we want to consider where we want these to live as they seem a little bit beyond 'Foundational' (definitely not something to worry about just now, we can do this at a later date).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jmcook1186 This is great! Love to see the expansion of these resources within the repo.
Left a few small comments/suggestions/questions, but overall think this is great and looking forward to pulling it in!
src/content/developers/docs/consensus-mechanisms/pos/gasper/index.md
Outdated
Show resolved
Hide resolved
src/content/developers/docs/consensus-mechanisms/pos/gasper/index.md
Outdated
Show resolved
Hide resolved
src/content/developers/docs/consensus-mechanisms/pos/gasper/index.md
Outdated
Show resolved
Hide resolved
Just waiting on another review before merging. |
@@ -3,85 +3,63 @@ title: Proof-of-stake (PoS) | |||
description: An explanation of the proof-of-stake consensus protocol and its role in Ethereum. | |||
lang: en | |||
sidebar: true | |||
incomplete: true | |||
incomplete: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI having incomplete: false
, while more explicit, isn't necessary. We can just remove this frontmatter prop ✂️
We only need to add incomplete: true
if we want to display the incomplete banner & callouts on a docs page.
src/content/developers/docs/consensus-mechanisms/pos/gasper/index.md
Outdated
Show resolved
Hide resolved
src/content/developers/docs/consensus-mechanisms/pos/weak-subjectivity/index.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💪🏻
Description
This PR is part of the migration of materials from eth.wiki to ethereum.org. There is substantial material on eth.wiki concerning proof of stake that was not available at ethereum.org and should not be lost when the wiki is deprecated. The PoS page currently on ethereum.org is also rather sparse and makes frequent reference to sharding designs that have since been deprecated. For these reasons I have reworked the PoS landing page with up-to-date information and also added two new subpages: one on weak subjectivity and another explaining the Gasper protocol. This satisfies the migration of PoS materials from eth.wiki. Note, however, that the material there was written when Casper was the cutting edge of PoS research, meaning it lags significantly behind the mechanism that will be implemented at the merge. Therefore, I have rewritten and updated where necessary.
In summary the following changes are implemented:
Note also that, contrary to the suggestions in the wiki migration issue I decided NOT to migrate the PoS FAQs onto ethereum.org. This is because they are already replicated verbatim on vitalik.ca. I have simply linked out to that page instead.
Related Issue
#5690