Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate json-rpc information from ethdocs/eth.wiki #5922

Merged
merged 10 commits into from
May 5, 2022
Merged

Migrate json-rpc information from ethdocs/eth.wiki #5922

merged 10 commits into from
May 5, 2022

Conversation

jmcook1186
Copy link
Contributor

@jmcook1186 jmcook1186 commented Apr 6, 2022

Description

This PR adds information from eth,wiki and ethdocs.org to ethereum.org/en/developers/docs/apis/json-rpc/.

Note that the key information is really the JSON-RPC API spec, which used to be included in full on the wiki but is not held externally - I have linked out to it.

In the preservationist spirit, and because I thought it was useful information not available elsewhere, I incorporated the short RPC contract deployment tutorial from ethdocs.org into this page.

Related Issue

#5731 and #5690

@github-actions github-actions bot added content 🖋️ This involves copy additions or edits review needed 👀 labels Apr 6, 2022
@gatsby-cloud
Copy link

gatsby-cloud bot commented Apr 6, 2022

Gatsby Cloud Build Report

ethereum-org-website-dev

🎉 Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

🕐 Build time: 9m

Performance

Lighthouse report

Metric Score
Performance 🔶 26
Accessibility 💚 100
Best Practices 💚 92
SEO 💚 92

🔗 View full report

@jmcook1186 jmcook1186 marked this pull request as ready for review April 7, 2022 09:26
@@ -24,6 +19,202 @@ Ethereum clients each may utilize different programming languages when implement

While you may choose to interact directly with Ethereum clients via the JSON-RPC API, there are often easier options for dapp developers. Many [JavaScript](/developers/docs/apis/javascript/#available-libraries) and [backend API](/developers/docs/apis/backend/#available-libraries) libraries exist to provide wrappers on top of the JSON-RPC API. With these libraries, developers can write intuitive, one-line methods in the programming language of their choice to initialize JSON-RPC requests (under the hood) that interact with Ethereum.

## Spec {#spec}

The full JSON-RPC API spec is available [here](https://github.com/ethereum/execution-apis).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

src/content/developers/docs/apis/json-rpc/index.md Outdated Show resolved Hide resolved

#### Hex value encoding {#hex-encoding}

At present there are two key datatypes that are passed over JSON: unformatted byte arrays and quantities. Both are passed with a hex encoding, however with different requirements to formatting:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At present

Is this going to change?

src/content/developers/docs/apis/json-rpc/index.md Outdated Show resolved Hide resolved
src/content/developers/docs/apis/json-rpc/index.md Outdated Show resolved Hide resolved
src/content/developers/docs/apis/json-rpc/index.md Outdated Show resolved Hide resolved
src/content/developers/docs/apis/json-rpc/index.md Outdated Show resolved Hide resolved
src/content/developers/docs/apis/json-rpc/index.md Outdated Show resolved Hide resolved
src/content/developers/docs/apis/json-rpc/index.md Outdated Show resolved Hide resolved
@minimalsm
Copy link
Contributor

Left a few comments, but I'm in no position to comment on whether it covers the right things or not 😅. However, it is fairly clear and reads well so it gets my blessing.

Copy link
Member

@wackerow wackerow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jmcook1186 Looks good, fills this page out nicely. Left a couple small code tweak suggestions which shouldn't be controversial.

Only other thought I had related to this would be potentially breaking the nested tutorial here off into an actual tutorial for the /developers/tutorials section of the site. I think this is great for now though and we can discuss that potentially in the future.

src/content/developers/docs/apis/json-rpc/index.md Outdated Show resolved Hide resolved
src/content/developers/docs/apis/json-rpc/index.md Outdated Show resolved Hide resolved
src/content/developers/docs/apis/json-rpc/index.md Outdated Show resolved Hide resolved
src/content/developers/docs/apis/json-rpc/index.md Outdated Show resolved Hide resolved
src/content/developers/docs/apis/json-rpc/index.md Outdated Show resolved Hide resolved
src/content/developers/docs/apis/json-rpc/index.md Outdated Show resolved Hide resolved
src/content/developers/docs/apis/json-rpc/index.md Outdated Show resolved Hide resolved
src/content/developers/docs/apis/json-rpc/index.md Outdated Show resolved Hide resolved
src/content/developers/docs/apis/json-rpc/index.md Outdated Show resolved Hide resolved
src/content/developers/docs/apis/json-rpc/index.md Outdated Show resolved Hide resolved
Copy link
Member

@wackerow wackerow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jmcook1186 Went ahead and committed the small adjustments I suggested. Will double check that this all builds correctly before merging, but think this is good to go! 🎉

@minimalsm
Copy link
Contributor

Murggginnnn 🚀

@minimalsm minimalsm merged commit 3815d7c into ethereum:dev May 5, 2022
@minimalsm minimalsm mentioned this pull request May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content 🖋️ This involves copy additions or edits
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants