Skip to content
This repository has been archived by the owner on Dec 17, 2024. It is now read-only.

munmap not delete the right address range #127

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/libethash/internal.c
Original file line number Diff line number Diff line change
Expand Up @@ -447,7 +447,7 @@ ethash_full_t ethash_full_new_internal(

fail_free_full_data:
// could check that munmap(..) == 0 but even if it did not can't really do anything here
munmap(ret->data, (size_t)full_size);
munmap(ret->data - ETHASH_DAG_MAGIC_NUM_SIZE, (size_t)full_size + ETHASH_DAG_MAGIC_NUM_SIZE);
fail_close_file:
fclose(ret->file);
fail_free_full:
Expand All @@ -469,7 +469,7 @@ ethash_full_t ethash_full_new(ethash_light_t light, ethash_callback_t callback)
void ethash_full_delete(ethash_full_t full)
{
// could check that munmap(..) == 0 but even if it did not can't really do anything here
munmap(full->data, (size_t)full->file_size);
munmap(full->data - ETHASH_DAG_MAGIC_NUM_SIZE, (size_t)full->file_size + ETHASH_DAG_MAGIC_NUM_SIZE);
if (full->file) {
fclose(full->file);
}
Expand Down