Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Basic validator custody #3871

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from
Open

Basic validator custody #3871

wants to merge 4 commits into from
+20 −0

Conversation

fradamt
Copy link
Contributor

@fradamt fradamt commented Aug 7, 2024

Moving the validator custody portion of #3779 into its own PR

@jtraglia jtraglia added the EIP-7594 PeerDAS label Aug 8, 2024
asn-d6
asn-d6 approved these changes Aug 8, 2024
View reviewed changes
Copy link
Contributor

@asn-d6 asn-d6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

jimmygchen
jimmygchen approved these changes Aug 14, 2024
View reviewed changes
Copy link
Contributor

@jimmygchen jimmygchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

ralexstokes
ralexstokes approved these changes Aug 29, 2024
View reviewed changes
Copy link
Member

@ralexstokes ralexstokes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

ppopth
ppopth approved these changes Oct 1, 2024
View reviewed changes
Copy link
Member

@ppopth ppopth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cskiraly
Copy link
Contributor

lgtm

g11tech
g11tech approved these changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@g11tech g11tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtraglia jtraglia jtraglia approved these changes

@g11tech g11tech g11tech approved these changes

@dapplion dapplion dapplion approved these changes

@asn-d6 asn-d6 asn-d6 approved these changes

@ralexstokes ralexstokes ralexstokes approved these changes

@jimmygchen jimmygchen jimmygchen approved these changes

@ppopth ppopth ppopth approved these changes

Assignees
No one assigned
Labels
DO NOT MERGE EIP-7594 PeerDAS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@fradamt @cskiraly @ppopth @jimmygchen @ralexstokes @asn-d6 @dapplion @g11tech @jtraglia @hwwhww