🐳 Dockerize spec tests #3475
🐳 Dockerize spec tests #3475
Conversation
docker/Dockerfile
Outdated
|
|
||
| COPY . . | ||
|
|
||
| RUN pip install -r requirements-dev.txt -r requirements_preinstallation.txt |
There was a problem hiding this comment.
requirements_preinstallation.txtshould be installed beforerequirements-dev.txt- Can
python -m pip install -e .[test]replacepip install -r requirements-dev.txtso that we don't need to maintainrequirements-dev.txtfile?
There was a problem hiding this comment.
requirements_preinstallation.txtshould be installed beforerequirements-dev.txt
You are right indeed.
- Can
python -m pip install -e .[test]replacepip install -r requirements-dev.txtso that we don't need to maintainrequirements-dev.txtfile?
Indeed good idea !
There was a problem hiding this comment.
Good job! It looks like it was run successfully with GitHub Action?
/cc @michaelneuder if you have some suggestions. :)
Co-authored-by: Hsiao-Wei Wang <[email protected]>
|
What the GitHub action is doing is to run pylint on the folder |
Yes it runs successfully 😄
|
|
Is there any additional help you need here? I'm wanting to work on an issue with the tests and am new to consensus-specs so it would be awesome if I can use a docker version of the spec-tests. |
IDK, there are works done here #3477 by @parithosh regarding the CI. |
| @@ -76,6 +76,18 @@ Options: | |||
| - `--disable-bls`, to disable BLS (only for tests that can run without) | |||
| - `--bls-type`, `milagro` or `py_ecc` (default) | |||
|
|
|||
| #### With Docker | |||
|
|
|||
| Run `docker build -f ./docker/Dockerfile -t consensus-specs .` from the root of the specs repository to build the test image. | |||
There was a problem hiding this comment.
When I ran the docker command, I first thought the sentence meant that the docker command should run inside spec/ and not the root folder of the repo. Not sure if you want to clarify that but just thought it worth mentioning.
Great work on this!
There was a problem hiding this comment.
Understood, does replacing from the root of the specs repository by from the repository root make it more understandable?
|
Not needed anymore. |
Thank you very much for the initial PR! happy to iterate on the approach taken in the merged one |
Associated to #3395
Docker may help us to facilitate the test running accros system and python versions.
First you need to build the image; be at the root of the project and run
docker build -f ./docker/Dockerfile -t consensus-specs ..Then you can locate yourself in "./scripts" and run "run_test.sh".
What was added
Dockerfilethat contains the consensus-specs project..dockerfileto ignore potentialvenvfolders.run_test.shto run project tests.arequirements-dev.txtcontaining all dependencies to run the tests.a scriptdockerfile_test.shto test theDockerfileconsistency.TODO
add a CircleCI process to testDockerfileconsistencyDockerfileconsistency