Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ERC: Chain-specific addresses using ENS #735

Open
wants to merge 18 commits into
base: master
Choose a base branch
from

Conversation

jrudolf
Copy link

@jrudolf jrudolf commented Nov 27, 2024

No description provided.

@eip-review-bot
Copy link
Collaborator

eip-review-bot commented Nov 27, 2024

File ERCS/erc-7828.md

Requires 1 more reviewers from @axic, @g11tech, @SamWilsn, @xinbenlv

@eip-review-bot eip-review-bot changed the title Add ERC: chain-specific addresses using ENS Add ERC: Chain-specific addresses using ENS Nov 27, 2024
@eip-review-bot eip-review-bot enabled auto-merge (squash) November 27, 2024 10:45
eip-review-bot
eip-review-bot previously approved these changes Nov 27, 2024
Copy link
Collaborator

@eip-review-bot eip-review-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@github-actions github-actions bot added the w-ci label Nov 27, 2024

The resolution of a `address@chain` on the contrary, imposes that the left-hand resolves to an address and the right-hand to a chain identifier.

When given a `[email protected]`, the wallet can resolve `rollup.eth` to get a chain identifier and `user.rollup.eth` to get an address. In any other case it fails.
Copy link

@niran niran Nov 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't require a new syntax: When the wallet is resolving user.rollup.eth, the standard resolution process should be resolve to resolve the way you described: resolve rollup.eth to get a chain identifier and user.rollup.eth to get an address.

This approach also allows user.rollup.eth to override this behavior by setting a record for their own preferred chain identifier to use when their ENS name is resolved. *.rollup.eth names will likely never override this, but I'd expect almost every user.eth to want to receive funds on some chain that isn't L1.

```
### Note: default fallbacks

If a user receives a legacy address without chain name, the wallet can:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think any of these fallbacks should be our target behavior. Users should be able to control on which chain assets sent to their ENS name arrive. I think ENS experts should lead the way on this resolution process via an ENSIP.

account ::= <user>@<chain>
```

Note the difference between `ens-name`, which is a full ENS name, and `ens-subdomain` that is just a segment of a name between dots. E.g. `user.app.eth` is a name, `user` and `app` are subdomains.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the below examples, isn't the user also just <address> | <ens-name>?

auto-merge was automatically disabled December 2, 2024 17:50

Head branch was pushed to by a user without write access

@github-actions github-actions bot removed the w-ci label Dec 2, 2024
@github-actions github-actions bot added the w-ci label Dec 2, 2024
ERCS/erc-7828.md Outdated Show resolved Hide resolved
@github-actions github-actions bot added w-ci and removed w-ci labels Dec 3, 2024
@github-actions github-actions bot removed the w-ci label Dec 3, 2024
Copy link

github-actions bot commented Dec 3, 2024

The commit d740aa0 (as a parent of 04618e3) contains errors.
Please inspect the Run Summary for details.

@github-actions github-actions bot added the w-ci label Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants