Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ERC: Access Control Registry #723

Merged

Conversation

shubh-ta
Copy link
Contributor

When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md

We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met:

  • The PR edits only existing draft PRs.
  • The build passes.
  • Your GitHub username or email address is listed in the 'author' header of all affected PRs, inside .
  • If matching on email address, the email address is the one publicly listed on your GitHub profile.

@eip-review-bot
Copy link
Collaborator

eip-review-bot commented Nov 19, 2024

✅ All reviewers have approved.

@eip-review-bot eip-review-bot changed the title Add: Access Control Registry Standard Add ERC: Access Control Registry Nov 19, 2024
ERCS/erc-xxxx.md Outdated Show resolved Hide resolved
ERCS/erc-xxxx.md Outdated Show resolved Hide resolved
Copy link

@Joj501 Joj501 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the err and add ERC

@anushka642000
Copy link

@Joj501 Could you clarify which specific error you're referring to?

@shubh-ta shubh-ta requested a review from abcoathup November 26, 2024 11:33
Copy link

The commit bf21f1a (as a parent of 48b3f97) contains errors.
Please inspect the Run Summary for details.

@github-actions github-actions bot added the w-ci label Nov 26, 2024
ERCS/erc-7820.md Outdated Show resolved Hide resolved
ERCS/erc-7820.md Show resolved Hide resolved
ERCS/erc-7820.md Show resolved Hide resolved
ERCS/erc-7820.md Outdated Show resolved Hide resolved
ERCS/erc-7820.md Show resolved Hide resolved
ERCS/erc-7820.md Outdated Show resolved Hide resolved
ERCS/erc-7820.md Outdated Show resolved Hide resolved
ERCS/erc-7820.md Outdated Show resolved Hide resolved
ERCS/erc-7820.md Outdated

#### Robust Security Measures

**Admin-Only Operations**: Functions that modify the state, such as unRegisterContract, _grantRole, and _revokeRole, are restricted to contract admins. This ensures that only authorized personnel can manage contracts and roles, reducing the risk of unauthorized changes.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similarly, _grantRole and _revokeRole don't appear in the Specification.

ERCS/erc-7820.md Outdated
## Reference Implementation

```solidity
// SPDX-License-Identifier: MIT
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code that's inline in the document itself must be CC0-1.0 licensed. We do allow MIT in the assets/ directory if you'd like to link to it there.

@shubh-ta shubh-ta requested a review from SamWilsn December 4, 2024 08:16
ERCS/erc-7820.md Outdated Show resolved Hide resolved
@eip-review-bot eip-review-bot enabled auto-merge (squash) December 10, 2024 16:08
Copy link
Collaborator

@eip-review-bot eip-review-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

Copy link
Collaborator

@eip-review-bot eip-review-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@eip-review-bot eip-review-bot merged commit 480e948 into ethereum:master Dec 10, 2024
10 checks passed
@github-actions github-actions bot removed the w-ci label Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants