-
Notifications
You must be signed in to change notification settings - Fork 489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ERC: ZK Identity Registry #710
base: master
Are you sure you want to change the base?
Conversation
The commit bd71ab8 (as a parent of dda5f4c) contains errors. |
assets/erc-7812/images/diagram.png
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have a slight preference for SVG diagrams, but if you cannot provide one PNG is acceptable. Do keep in mind that some people (myself included) use light mode.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noted. If possible, I would like to keep a PNG.
ERCS/erc-7812.md
Outdated
|
||
## Abstract | ||
|
||
This EIP introduces an on-chain registry system for storing abstract statements, where the state of the system can be proven in zero knowledge without disclosing anything about these statements. Developers may use the singleton `EvidenceRegistry` contract available at `0x<TODO>` to integrate custom business-specific registrars for statement processing and proving. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to see a bit more technical meat in your abstract. I have zero zero knowledge knowledge, so I'm probably a good guinea pig for the average ERC reader. You could answer questions like: why do you need a registry to prove zk statements? Why does it need to be a singleton?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rewrote the abstract part. Added a few sentences about the singleton design in the rationale section.
Would love to see our recent work as an ERC!
ZK Identity Registry - Singleton registry system for storing abstract provable identity statements.
The complete reference implementation can be found here.