Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ERC: ZK Identity Registry #710

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Conversation

Arvolear
Copy link
Contributor

@Arvolear Arvolear commented Nov 8, 2024

Would love to see our recent work as an ERC!


ZK Identity Registry - Singleton registry system for storing abstract provable identity statements.

The complete reference implementation can be found here.

@eip-review-bot
Copy link
Collaborator

eip-review-bot commented Nov 8, 2024

File ERCS/erc-7812.md

Requires 1 more reviewers from @g11tech, @SamWilsn, @xinbenlv

ERCS/erc-xxxx.md Outdated Show resolved Hide resolved
ERCS/erc-xxxx.md Outdated Show resolved Hide resolved
ERCS/erc-xxxx.md Outdated Show resolved Hide resolved
@Arvolear Arvolear changed the title Add ERC: ZK Identity Registry Add ERC-7812: ZK Identity Registry Nov 10, 2024
@github-actions github-actions bot removed the w-ci label Nov 10, 2024
@eip-review-bot eip-review-bot changed the title Add ERC-7812: ZK Identity Registry Add ERC: ZK Identity Registry Nov 10, 2024
Copy link

The commit bd71ab8 (as a parent of dda5f4c) contains errors.
Please inspect the Run Summary for details.

@github-actions github-actions bot added the w-ci label Nov 10, 2024
@github-actions github-actions bot removed the w-ci label Nov 10, 2024
ERCS/erc-7812.md Outdated Show resolved Hide resolved
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have a slight preference for SVG diagrams, but if you cannot provide one PNG is acceptable. Do keep in mind that some people (myself included) use light mode.

Copy link
Contributor Author

@Arvolear Arvolear Dec 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noted. If possible, I would like to keep a PNG.

ERCS/erc-7812.md Outdated Show resolved Hide resolved
ERCS/erc-7812.md Outdated

## Abstract

This EIP introduces an on-chain registry system for storing abstract statements, where the state of the system can be proven in zero knowledge without disclosing anything about these statements. Developers may use the singleton `EvidenceRegistry` contract available at `0x<TODO>` to integrate custom business-specific registrars for statement processing and proving.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to see a bit more technical meat in your abstract. I have zero zero knowledge knowledge, so I'm probably a good guinea pig for the average ERC reader. You could answer questions like: why do you need a registry to prove zk statements? Why does it need to be a singleton?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rewrote the abstract part. Added a few sentences about the singleton design in the rationale section.

ERCS/erc-7812.md Outdated Show resolved Hide resolved
ERCS/erc-7812.md Outdated Show resolved Hide resolved
ERCS/erc-7812.md Outdated Show resolved Hide resolved
ERCS/erc-7812.md Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants