-
Notifications
You must be signed in to change notification settings - Fork 489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ERC-7656: Move to Last Call #698
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You cannot move to Last Call until 6551 (as a dependency) also moves to last call. It's awkward, but if you only vaguely allude to 6551 (without using its number) you can advance to Last Call.
Please triple check your interface id before going to final.
…to move-erc7656-to-last-call
I did it.
Done, many times :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've taken the liberty of copying the security considerations into this proposal, and correcting the license on your reference implementation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All Reviewers Have Approved; Performing Automatic Merge...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All Reviewers Have Approved; Performing Automatic Merge...
Head branch was pushed to by a user without write access
That is great, thanks. However, those anti-fraud considerations are applicable only if we talk about linked accounts. So, I specified it in the title of the sub-section. I am afraid you have to approve it again :( |
The commit 871d897 (as a parent of a467b74) contains errors. |
This ERC is very stable and has been used in more than one project (for example in Zazook NFT, where 7656 is used to deploy a subscription service associated to the NFT).
Time to move to Last Call.