Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ERC-7656: Move to Last Call #698

Open
wants to merge 17 commits into
base: master
Choose a base branch
from

Conversation

sullof
Copy link
Contributor

@sullof sullof commented Nov 4, 2024

This ERC is very stable and has been used in more than one project (for example in Zazook NFT, where 7656 is used to deploy a subscription service associated to the NFT).
Time to move to Last Call.

@eip-review-bot
Copy link
Collaborator

eip-review-bot commented Nov 4, 2024

File ERCS/erc-7656.md

Requires 1 more reviewers from @g11tech, @SamWilsn, @xinbenlv

@eip-review-bot eip-review-bot changed the title Moving to last call Update ERC-7656: Move to Last Call Nov 4, 2024
Copy link
Collaborator

@SamWilsn SamWilsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You cannot move to Last Call until 6551 (as a dependency) also moves to last call. It's awkward, but if you only vaguely allude to 6551 (without using its number) you can advance to Last Call.


Please triple check your interface id before going to final.

@sullof
Copy link
Contributor Author

sullof commented Nov 26, 2024

You cannot move to Last Call until 6551 (as a dependency) also moves to last call. It's awkward, but if you only vaguely allude to 6551 (without using its number) you can advance to Last Call.

I did it.

Please triple check your interface id before going to final.

Done, many times :-)

@github-actions github-actions bot added the w-ci label Nov 26, 2024
@github-actions github-actions bot removed the w-ci label Nov 26, 2024
SamWilsn
SamWilsn previously approved these changes Dec 9, 2024
Copy link
Collaborator

@SamWilsn SamWilsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've taken the liberty of copying the security considerations into this proposal, and correcting the license on your reference implementation.

@eip-review-bot eip-review-bot enabled auto-merge (squash) December 9, 2024 18:01
Copy link
Collaborator

@eip-review-bot eip-review-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@github-actions github-actions bot added the w-ci label Dec 9, 2024
eip-review-bot
eip-review-bot previously approved these changes Dec 10, 2024
Copy link
Collaborator

@eip-review-bot eip-review-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

auto-merge was automatically disabled December 10, 2024 13:49

Head branch was pushed to by a user without write access

@sullof sullof dismissed stale reviews from eip-review-bot and SamWilsn via 533b08c December 10, 2024 13:49
@github-actions github-actions bot removed the w-ci label Dec 10, 2024
@sullof
Copy link
Contributor Author

sullof commented Dec 10, 2024

I've taken the liberty of copying the security considerations into this proposal, and correcting the license on your reference implementation.

That is great, thanks. However, those anti-fraud considerations are applicable only if we talk about linked accounts. So, I specified it in the title of the sub-section. I am afraid you have to approve it again :(

@github-actions github-actions bot added the w-ci label Dec 10, 2024
Copy link

The commit 871d897 (as a parent of a467b74) contains errors.
Please inspect the Run Summary for details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants