Validation: wrap local chain info maps with mutexes #669
+17
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Appears that there's a race when attempting to update local chain ID/Name maps from multiple tests which are kicked off concurrently. * Also refactored the code a bit to wrap the global vars into a struct
geoknee
reviewed
Nov 4, 2024
Thanks for the suggestion, agree that's much simpler to use for this case and modified code accordingly. |
geoknee
approved these changes
Nov 4, 2024
priyanshuthapliyal55
pushed a commit
to priyanshuthapliyal55/superchain-registry
that referenced
this pull request
Dec 6, 2024
…m#669) * Validation: wrap local chain info maps with mutexes * Appears that there's a race when attempting to update local chain ID/Name maps from multiple tests which are kicked off concurrently. * Also refactored the code a bit to wrap the global vars into a struct * Use sync.Map, simpler code --------- Co-authored-by: Vinod Damle <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
I have declared the chain at the appropriate Superchain Level.just validate <chain-id>locally to ensure all local validation checks pass.just codegento ensure that the chainlist and other generated files are up-to-date and include my chain.ref: #668