Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal to reorganize OP Stack contracts folder structure #148

Merged

Conversation

AmadiMichael
Copy link
Member

This design doc proposes moving the Cannon and Dispute contracts into the L1 folder since they are actually L1 contracts.

Issue: ethereum-optimism/optimism#12643

@smartcontracts
Copy link
Contributor

smartcontracts commented Oct 31, 2024

I would also propose the following:

  • legacy is removed in favor of universal/legacy, L1/legacy, L2/legacy etc
  • periphery is removed in favor of universal/periphery, L1/periphery, L2/periphery etc
  • governance is moved into L2/governance
  • safe is moved into universal/safe

@AmadiMichael AmadiMichael changed the title move cannon and dispute folders to L1 folder Proposal to reorganize OP Stack contracts folder structure Oct 31, 2024
Copy link
Contributor

@smartcontracts smartcontracts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah this LGTM, I vote we do one giant design doc review for the various design docs you've opened over the last few days

@AmadiMichael
Copy link
Member Author

Discussed in #150. Conclusion was to implement as described in the design doc.

@AmadiMichael AmadiMichael merged commit 5e279be into main Nov 4, 2024
@AmadiMichael AmadiMichael deleted the amadi/move-cannon-and-dispute-folders-to-L1-folder branch November 4, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants