Use modulo instead of and operation to validate the proof size #101
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The slow implementation loads the
_proof
length from calldata and checks that this length is a multiple of 60.However, this check uses a logical AND which may lead to accepting invalid values that are not multiple of 60.
Moreover, the check is insufficient.
_proof
is expected to be a multiple of60 * 32
, however only the fact that it is a multiple of 60 is checked.The logical AND check should be replaced with a modulo operation to ensure that it is a multiple of
32 * 60
.