Add beforeDelete transform #70
Conversation
carlbennettnz
force-pushed
the
before-delete-transform
branch
from
deda53b to
bf9fb89
Compare
|
Thanks! I don't have much time tonight, but I'll take a look at this tomorrow and let you know. |
|
No problem |
carlbennettnz
force-pushed
the
before-delete-transform
branch
from
bf9fb89 to
608d5cd
Compare
|
|
||
| // Your route definitions would go here, but if none match... | ||
|
|
||
| app.use(function(req, res, next) { |
There was a problem hiding this comment.
Rather than putting this example here, can you link to the line with the same code in the example repo? That way, we don't have to keep this code up to date in two places, and (more importantly) people won't get confused about what Front is.
|
Well the tests pass for me locally :/ |
|
I still can't reproduce the problem Circle's facing. If you run these tests locally, do they pass for you? |
The id list is deliberately not replaced with the value returned from the transform as the user should not be able to silently remove ids from the id list. Therefore, this 'transform' should be used purely as a way to throw errors when the requested deletion is not allowed. Closes ethanresnick#66
carlbennettnz
force-pushed
the
before-delete-transform
branch
from
e75a991 to
0f5d81d
Compare
|
Any chance we could get this fixed and merged within the next few days? I'm almost ready to switch my company's app over to JSON API and I would rather use an official version of this library if possible. |
Awesome!
I'll take a look at it later this week or over the weekend. Basically, this hasnt beee merged yet only because it feels like we need to solve #28 first, and better account for all the different types of delete requests. |
|
Any update on this? |
Closes #66
I gave the integration tests a shot, but the first one breaks another test and the second doesn't work at all. How should I be doing this?