Fix pandora #57
Open
Fix pandora #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The framework is implemented in the Playback Control skill (https://github.com/mycroftai/skill-playback-control)
For now, the same common_play_skill.py will live in several independent skills with the same content.
Implement the common play framework
Updated translations: ['sv-se', 'ru-ru']
Fixes broken icon-link in Readme
Update README.md
Updated translations: ['sv-se', 'de-de', 'ru-ru', 'es-es']
Updated translations: ['sv-se', 'de-de', 'ru-ru']
This checks if the reason for pianobar erroring is actually an invalid username and password by simulating the login api on the website
For users that need to manually install pianobar, its helpful to have it fail so that it will notify them they need to perform a manual step first
Fail if requirements.sh doesn't find pianobar
Verify username and passsword doesn't work before erroring
Updated translations
* Removed the explicit (untranslated) removal of "on", "pandora" and "play" in _extract_station(). They are already removed by the vocab removal. Also eliminated the removal of "to" as this seemed arbitrary. * Boosted the score of just "play Pandora" to MULTI_KEY. It was being caught by Spotify instead -- presumably because it was matching on some song with "Pandora" in the title. * Better handling of missing Pianobar "info" file
Check if the Pandora process remains valid after launching. If the username/password is incorrect, the pianobar process will self destruct. Also enhanced the error message spoken in this case.
Allow installs on systems without pkcon
The lsb_release approach failed on the skill tester.
Boneheaded bug in the requirements.sh script meant that systems with pkcon would not define the list of dependencies to install, so nothing would be installed.
It wasn't always clear what service is being used with Common Play. This clarifies it.
Odd merge conflict with #30. Same fix here from @krisgesling
Fixes bug where station number is spoken
Removed deprecated values from Skills settingsmeta.json (reported in issue #1092).
Updated translations
Remove deprecated values (name, color)
Updated translations
Updated translations
Updated translations
Updated translations
Information on currently and recently played items was being stored in the Skill settings causing the settings to stop syncing on mycroft-core v20.8.1. This moves all values that are not Skill settings to a local json database stored in the Skills namespaced filesystem.
Fix settings won't sync on core v20.8.1
The previous requirements.sh script was created prior to Mycroft performing package installs on multiple systems. This is now handled by Pako which supports more packaging systems.
Switch dependency definitions to manifest.yml
1 task
|
This was opened against the wrong repo. Have replicated against the Mycroft fork, see above. This PR can be closed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrects bad shutdown behavior which caused entire system to lose audio out.