Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use custom AppBar #122

Merged
merged 1 commit into from
Jan 24, 2021
Merged

Use custom AppBar #122

merged 1 commit into from
Jan 24, 2021

Conversation

zecakeh
Copy link
Contributor

@zecakeh zecakeh commented Jan 23, 2021

Allows us to always provide the menu as fallback, especially useful on Web.

This fixes #96.
I went for the simplest solution, because it will only be necessary on small screens when #106 is done.

Copy link
Member

@tasn tasn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this something that's supported/recommended by RN-paper/navigation people? To use a custom header? If so, I'm fine with it in principle (just need to fix the comments).

src/widgets/MenuButton.tsx Show resolved Hide resolved
src/RootNavigator.tsx Show resolved Hide resolved
src/widgets/AppBar.tsx Outdated Show resolved Hide resolved
src/widgets/AppBar.tsx Outdated Show resolved Hide resolved
src/widgets/AppBar.tsx Outdated Show resolved Hide resolved
src/widgets/AppBar.tsx Outdated Show resolved Hide resolved
@zecakeh
Copy link
Contributor Author

zecakeh commented Jan 23, 2021

Is this something that's supported/recommended by RN-paper/navigation people? To use a custom header? If so, I'm fine with it in principle (just need to fix the comments).

It is supported as I picked up some of the code from the documentation.

src/widgets/AppBar.tsx Outdated Show resolved Hide resolved
src/widgets/AppBar.tsx Outdated Show resolved Hide resolved
@tasn
Copy link
Member

tasn commented Jan 24, 2021

Anyhow, looks good. Just fix the if issues and this can be merged.

Allows us to always provide the menu as fallback, especially useful on Web.
@zecakeh
Copy link
Contributor Author

zecakeh commented Jan 24, 2021

Changes implemented, ready to merge.

@tasn tasn merged commit d011a0b into etesync:master Jan 24, 2021
@zecakeh zecakeh deleted the custom-appbar branch January 24, 2021 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide navigation options when opening web version from URL
2 participants