Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ethernaut-optigov proposals task #40

Open
wants to merge 7 commits into
base: feature/optigov
Choose a base branch
from

Conversation

luisvid
Copy link
Collaborator

@luisvid luisvid commented Oct 24, 2024

RetroPGF Proposals Task

This PR introduces a proposals task to retrieve data related to RetroPGF proposals. The task provides functionality to list and filter proposals by various parameters, offering detailed proposal information upon request.

Usage

The command retrieves RetroPGF proposals with optional filters, providing flexibility in output.

$ ethernaut optigov proposals [--limit <INT>] [--offset <INT>] [--proposal-id <STRING>] [--votes <STRING>]

Examples

Retrieve All Proposals

$ ethernaut optigov proposals

Result:

╭ Proposals ───────────────────────────────────────────────────────────────────────────────╮
│                                                                                          │
│   - Id: 73810549639625460608526212484168523508252711948247527324237096115535475508877    │
│     Title: Season 6: Standard Rollup Charter Ratification                                │
│                                                                                          │
│   - Id: 50775220738623167695573388814398057544437236582252674861818535424434586434657    │
│     Title: Governor Update Proposal #3: Enable Onchain Treasury Execution                │
╰──────────────────────────────────────────────────────────────────────────────────────────╯

Retrieve Specific Proposal by ID

$ ethernaut optigov proposals --proposal-id 73810549639625460608526212484168523508252711948247527324237096115535475508877

Result:

╭ Proposal 73810549639625460608526212484168523508252711948247527324237096115535475508877 ───────────────────────────────────────────────────────╮
│                                                                                                                                               │
│   Id: 73810549639625460608526212484168523508252711948247527324237096115535475508877                                                           │
│   Title: Season 6: Standard Rollup Charter Ratification                                                                                       │
│   Description: # Season 6: Standard Rollup Charter Ratification                                                                               │
│   The Standard Rollup is the Optimism Collective’s flagship, high-security blockspace product. The Standard Rollup targets the Collective’s   │
│   highest bar for security, uptime, and decentralization.                                                                                     │
╰───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────╯

Retrieve Votes for a Specific Proposal

$ ethernaut optigov proposals --proposal-id 73810549639625460608526212484168523508252711948247527324237096115535475508877 --votes yes

Result:

╭ Votes for Proposal 73810549639625460608526212484168523508252711948247527324237096115535475508877 ─────────────────────────────────────────────╮
│                                                                                                                                               │
│   - Voter: 0x6eda5acaff7f5964e1ecc3fd61c62570c186ca0c, Support: FOR, Weight: 1438269908435335739147341, Reason: very exciting                 │
│                                                                                                                                               │
│   - Voter: 0x5c459147312928bd278837ed72a0c31cca0a5244, Support: FOR, Weight: 311210387303418696326773, Reason:                                │
│                                                                                                                                               │
│   - Voter: 0xfc10a71b1e7974401d840fd15cebf08ed7e115cc, Support: FOR, Weight: 170281313829982995759346, Reason: Per the October 22nd Token     │
│     House Call, the proposal seems reasonable and well thought out.                                                                           │
╰───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────╯

Final Status

  • This task is complete and ready for review.
  • All core functionality for retrieving and filtering proposals and votes has been implemented.
  • Testing added

@luisvid luisvid self-assigned this Oct 24, 2024
@coveralls
Copy link

coveralls commented Oct 24, 2024

Coverage Status

coverage: 67.873% (-0.3%) from 68.218%
when pulling 2c407fe on retro/proposals
into ff7214e on feature/optigov.

@luisvid luisvid changed the base branch from main to feature/optigov October 25, 2024 00:30
@luisvid luisvid marked this pull request as ready for review October 26, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants