Calldata decoding util #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eternauta1337
requested changes
Sep 17, 2024
raiseerco
force-pushed
the
onboarding/util-calldata
branch
from
f9d8c11 to
9f65eb3
Compare
eternauta1337
requested changes
Sep 25, 2024
There was a problem hiding this comment.
Looking good!
I just left some comments regarding something I still think you need to grasp: how plugins are completely standalone of their ui extension.
The etherscan abi suggestion logic must not live in the interact package, but instead reside 100% in the interact-ui package.
eternauta1337
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This utility takes the calldata of a transaction and its abi as a parameter to decode it and show in a human reading way.
Parameters: