Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct PAR1/2 start positions. #870

Merged
merged 1 commit into from
Mar 6, 2024

Conversation

rollf
Copy link
Contributor

@rollf rollf commented Mar 1, 2024

The start position was wrong because it was assuming a one-based coordinate system. However, these paremters are used in BED-context where coordinates are assumed zero-based. Since BED is right-open (i.e. the end coordinate is not within the interval), the end positions of PAR1/2 were actually correct.

For reference, here are some pictures that depict the difference between BED coordinates and "genomic" coordinates:

image-20240301-092030
(From NCBI)

image-20240301-091943
(N here are the telomeres. Chromosome X's first non-masked position (C, at 60,001) is the first position of PAR1)

image-20240301-092451

NCBI’s “2,649,520” (PAR1 end) is 2,649,519 in zero-based coordinates. However, BED’s end coordinate is not included (see above the screenshot: Although x-par1.bed contains 60,000 and 60,010 there are 10 (not 11) bases extracted, i.e. base 60,000 to base 60,009). Thus, using 2,649,519 as the end coordinate within a BED file would mean, the last base of PAR1 (“2,649,520” in NCBI’s coordinate system) would be omitted. Thus, we need to increment by one. The final BED numbers would be start=60,000;end=2,649,520 which equals NCBI’s start=60,001 and stop=2,649,520. Hence, this PR only decreases all start positions by one.

The start position was wrong because it was assuming a one-based
coordinate system. However, these paremters are used in BED-context
where coordinates are assumed zero-based. Since BED is right-open (i.e.
the end coordinate is *not* within the interval), the end positions of
PAR1/2 were actually correct.
@etal etal merged commit 80965db into etal:master Mar 6, 2024
1 of 6 checks passed
@etal
Copy link
Owner

etal commented Mar 6, 2024

Makes sense to me, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants