Use correct PAR1/2 start positions. #870
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The start position was wrong because it was assuming a one-based coordinate system. However, these paremters are used in BED-context where coordinates are assumed zero-based. Since BED is right-open (i.e. the end coordinate is not within the interval), the end positions of PAR1/2 were actually correct.
For reference, here are some pictures that depict the difference between BED coordinates and "genomic" coordinates:
(From NCBI)
(
N
here are the telomeres. Chromosome X's first non-masked position (C
, at 60,001) is the first position of PAR1)NCBI’s “2,649,520” (PAR1 end) is 2,649,519 in zero-based coordinates. However, BED’s end coordinate is not included (see above the screenshot: Although x-par1.bed contains 60,000 and 60,010 there are 10 (not 11) bases extracted, i.e. base 60,000 to base 60,009). Thus, using 2,649,519 as the end coordinate within a BED file would mean, the last base of PAR1 (“2,649,520” in NCBI’s coordinate system) would be omitted. Thus, we need to increment by one. The final BED numbers would be start=60,000;end=2,649,520 which equals NCBI’s start=60,001 and stop=2,649,520. Hence, this PR only decreases all start positions by one.