Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pagination): add currentPageText prop #17

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bmestanov
Copy link

Hi, I'm using i18n for a project and it looks like the part of the Pagination component reading Showing X-Y of Z is hardcoded, so I came up with a prop that allows custom formatting of the text given X, Y, Z.

Cheers.

@codecov
Copy link

codecov bot commented Nov 9, 2020

Codecov Report

Merging #17 (ed1ee00) into master (1b53901) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #17   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           29        29           
  Lines          495       497    +2     
  Branches        77        77           
=========================================
+ Hits           495       497    +2     
Flag Coverage Δ
unittest 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Pagination.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b53901...ed1ee00. Read the comment docs.

@estevanmaito
Copy link
Owner

Hey! This looks fantastic and its something that was annoying me. I'll take a better look on the weekend.

Thanks for the test too 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants