-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(video): fix uninitialized value #25
fix(video): fix uninitialized value #25
Conversation
2c547d8
to
6fbc52c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM,
Let's first merge this #24, and after that merge current (with CI verification).
6fbc52c
to
c92ceeb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can wait a bit (till the moment you done with the code) and release the new version after that.
Meanwhile, these changes LGTM.
901702e
to
dc92184
Compare
f31080d
to
669c4e4
Compare
669c4e4
to
ff7f67d
Compare
@peter-marcisovsky PTAL |
Describe the PR
Resolve a compilation error (uninitialized variable).
Resolve close endpoint error (error assert)