Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(video): fix uninitialized value #25

Merged

Conversation

lijunru-hub
Copy link

@lijunru-hub lijunru-hub commented Apr 28, 2024

Describe the PR
Resolve a compilation error (uninitialized variable).

image

Resolve close endpoint error (error assert)

image

@lijunru-hub lijunru-hub force-pushed the fix/video_uninitialized_value branch 2 times, most recently from 2c547d8 to 6fbc52c Compare April 30, 2024 07:25
@roma-jam roma-jam self-requested a review April 30, 2024 07:28
Copy link
Collaborator

@roma-jam roma-jam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,
Let's first merge this #24, and after that merge current (with CI verification).

src/class/video/video_device.c Outdated Show resolved Hide resolved
Copy link
Collaborator

@roma-jam roma-jam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can wait a bit (till the moment you done with the code) and release the new version after that.
Meanwhile, these changes LGTM.

@lijunru-hub lijunru-hub force-pushed the fix/video_uninitialized_value branch 2 times, most recently from 901702e to dc92184 Compare April 30, 2024 10:24
@lijunru-hub lijunru-hub changed the title fix(vedio): fix uninitialized value fix(vidio): fix uninitialized value Apr 30, 2024
@lijunru-hub lijunru-hub force-pushed the fix/video_uninitialized_value branch 2 times, most recently from f31080d to 669c4e4 Compare May 6, 2024 02:37
@lijunru-hub lijunru-hub force-pushed the fix/video_uninitialized_value branch from 669c4e4 to ff7f67d Compare May 6, 2024 02:38
@lijunru-hub
Copy link
Author

@peter-marcisovsky PTAL

@roma-jam roma-jam changed the title fix(vidio): fix uninitialized value fix(video): fix uninitialized value May 6, 2024
@roma-jam roma-jam merged commit 14f3f7c into espressif:release/v0.15 May 7, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants