[srp-client] improve Client::Start error handling (openthread#10834)

SRP Client close socket on connect error to avoid to fail the next time.
espressif · Oct 16, 2024 · 3a037f2 · 3a037f2
1 parent a225ee9
commit 3a037f2
Showing 1 changed file with 9 additions and 1 deletion.
diff --git a/src/core/net/srp_client.cpp b/src/core/net/srp_client.cpp
@@ -385,7 +385,15 @@ Error Client::Start(const Ip6::SockAddr &aServerSockAddr, Requester aRequester)
                  error = (aServerSockAddr == GetServerAddress()) ? kErrorNone : kErrorBusy);
 
     SuccessOrExit(error = mSocket.Open());
-    SuccessOrExit(error = mSocket.Connect(aServerSockAddr));
+
+    error = mSocket.Connect(aServerSockAddr);
+    if (error != kErrorNone)
+    {
+        LogInfo("Failed to connect to server %s: %s", aServerSockAddr.GetAddress().ToString().AsCString(),
+                ErrorToString(error));
+        IgnoreError(mSocket.Close());
+        ExitNow();
+    }
 
     LogInfo("%starting, server %s", (aRequester == kRequesterUser) ? "S" : "Auto-s",
             aServerSockAddr.ToString().AsCString());