Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ci_on_macos.yml (fix CI with latest mac at arm architecture) #5785

Merged
merged 6 commits into from
May 30, 2024

Conversation

ftshijt
Copy link
Collaborator

@ftshijt ftshijt commented May 22, 2024

What?

CI fix for MacOS

@ftshijt
Copy link
Collaborator Author

ftshijt commented May 22, 2024

FYI: actions/setup-python#808

@mergify mergify bot added the CI Travis, Circle CI, etc label May 22, 2024
@ftshijt ftshijt added the Bugfix label May 22, 2024
@ftshijt
Copy link
Collaborator Author

ftshijt commented May 22, 2024

Umm, it is not as easy as I thought since some c compiling is also having issues with M1 arm...

Copy link

codecov bot commented May 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.32%. Comparing base (1ea3fdf) to head (a615131).
Report is 28 commits behind head on master.

Current head a615131 differs from pull request most recent head f8fd91a

Please upload reports for the commit f8fd91a to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5785      +/-   ##
==========================================
- Coverage   62.77%   54.32%   -8.46%     
==========================================
  Files         153      771     +618     
  Lines       16958    70626   +53668     
==========================================
+ Hits        10646    38366   +27720     
- Misses       6312    32260   +25948     
Flag Coverage Δ
test_integration_espnet1 ?
test_python_espnet2 52.70% <ø> (?)
test_utils 20.61% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mergify mergify bot added the Installation label May 27, 2024
@ftshijt
Copy link
Collaborator Author

ftshijt commented May 27, 2024

Hi guys @sw005320 @kamo-naoyuki , I'm trying to fix the CI issue with MacOS but am not sure about the next move. Would be great if you have any comments:

The current issue is mostly from the change of MacOS-latest version being switched to M1 chip with arm architecture. After I change the ci test to arm architecture, two external tools start to have issues:

For the following fixes, we may think of removing sph2pipe from the default installation for MacOS test specifically (we still need it for other tests) or use our own fixed fork of the sph2pipe instead of their old release. May I ask which one you would prefer?

@sw005320
Copy link
Contributor

Hi @ftshijt,
Thanks for taking care of this!

My preference is

For the following fixes, we may think of removing sph2pipe from the default installation for MacOS test specifically (we still need it for other tests)

We may need this legacy format in the Linux environment, but we don't need it for MacOS.

@ftshijt ftshijt added the auto-merge Enable auto-merge label May 29, 2024
@ftshijt ftshijt merged commit 7080bb2 into master May 30, 2024
33 checks passed
@ftshijt ftshijt deleted the ftshijt-patch-2 branch May 30, 2024 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge Enable auto-merge Bugfix CI Travis, Circle CI, etc Installation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants