-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ci_on_macos.yml (fix CI with latest mac at arm architecture) #5785
Conversation
Umm, it is not as easy as I thought since some c compiling is also having issues with M1 arm... |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5785 +/- ##
==========================================
- Coverage 62.77% 54.32% -8.46%
==========================================
Files 153 771 +618
Lines 16958 70626 +53668
==========================================
+ Hits 10646 38366 +27720
- Misses 6312 32260 +25948
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Hi guys @sw005320 @kamo-naoyuki , I'm trying to fix the CI issue with MacOS but am not sure about the next move. Would be great if you have any comments: The current issue is mostly from the change of MacOS-latest version being switched to M1 chip with arm architecture. After I change the ci test to arm architecture, two external tools start to have issues:
For the following fixes, we may think of removing sph2pipe from the default installation for MacOS test specifically (we still need it for other tests) or use our own fixed fork of the sph2pipe instead of their old release. May I ask which one you would prefer? |
Hi @ftshijt, My preference is
We may need this legacy format in the Linux environment, but we don't need it for MacOS. |
What?
CI fix for MacOS