Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update index.md #981

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

TelefraggerRick
Copy link

@TelefraggerRick TelefraggerRick commented Jan 10, 2025

Brief description of the changes

Fixed GPIO numbers to P numbers for the wb3s board which comes native in device

Type of changes

  • New device
  • [x ] Update existing device
  • Removing a device
  • General cleanup
  • Other

Checklist:

  • There are no passwords or secrets references in any examples.
    The only exceptions are !secret wifi_ssid and !secret wifi_password.
  • The wifi or ethernet block has no static / manual ip address specified.
  • The first configuration provided should be hardware definitions only.
    A more involved example can be provided in a separate configuration block.

Copy link

netlify bot commented Jan 10, 2025

Deploy Preview for esphome-devices ready!

Name Link
🔨 Latest commit b49fff1
🔍 Latest deploy log https://app.netlify.com/sites/esphome-devices/deploys/678172cd9b2ce600084871ab
😎 Deploy Preview https://deploy-preview-981--esphome-devices.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 97 (🟢 up 2 from production)
Accessibility: 86 (no change from production)
Best Practices: 100 (no change from production)
SEO: 89 (no change from production)
PWA: 70 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@jesserockz jesserockz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should not wipe out the previous esp8266 based configuration. If there are new revisions of the device with different chip/configuration, you should make that clear and put the configuration below the existing with its own header.

@esphome esphome bot marked this pull request as draft January 16, 2025 01:32
@esphome
Copy link

esphome bot commented Jan 16, 2025

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@TelefraggerRick
Copy link
Author

You should not wipe out the previous esp8266 based configuration. If there are new revisions of the device with different chip/configuration, you should make that clear and put the configuration below the existing with its own header.

Hey Jesse,

I wiped it out since I don't believe this device was ever shipped with a ESP8266 but rather it was suggested, before the tuya-cloudcutter latest method, to remove the chip and replace it with a ESP. In that case the information provide was correct but is not correct with the device as its manufactured.

Whats the best way to include that in the pull? I'm not super familiar with workflow process in git hub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants