Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UART: Move RX/TX pin assignment from constructor to builder functions #2904

Merged
merged 7 commits into from
Jan 8, 2025
Merged

UART: Move RX/TX pin assignment from constructor to builder functions #2904

merged 7 commits into from
Jan 8, 2025
+129 −74

Conversation

JurajSadel
Copy link
Contributor

closes #2632

@bugadani bugadani mentioned this pull request Jan 8, 2025
Open
@JurajSadel
Copy link
Contributor Author

I ran uart, uart_async on ESP32 locally, and both test passed 🤔

@bjoernQ
Copy link
Contributor

bjoernQ commented Jan 8, 2025

I ran uart, uart_async on ESP32 locally, and both test passed 🤔

I tried uart_async locally and it fails for me the same way it does in CI. Changing the order of RX/TX as @bugadani suggested makes it work

Not sure we want to tell users they need to configure pins in that order, however

@JurajSadel JurajSadel mentioned this pull request Jan 8, 2025
Closed
@bjoernQ bjoernQ added this pull request to the merge queue Jan 8, 2025
Merged via the queue into esp-rs:main with commit 8a7f836 Jan 8, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjoernQ bjoernQ bjoernQ approved these changes

@bugadani bugadani bugadani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RX/TX pin assignment in UART driver is done in the constructor instead of builder functions
3 participants
@JurajSadel @bjoernQ @bugadani