Use own implementation instead of ROM functions, re-add memchr #2896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjoernQ
changed the title
MabezDev
reviewed
Jan 6, 2025
|
|
||
| // We cannot just use the ROM function since it calls `__getreent` | ||
| // | ||
| // From docs: The __getreent() function returns a per-task pointer to struct |
There was a problem hiding this comment.
I was looking into why on earth atoi needed to be reentrant, it seems it can set errno and therefore needs a thread local errno to set to avoid race conditions - annoying.
Dominaezzz
reviewed
Jan 6, 2025
esp-wifi/src/compat/misc.rs
Outdated
|
|
||
| unsafe { | ||
| let s = core::ffi::CStr::from_ptr(str); | ||
| let s = s.to_str().unwrap(); |
There was a problem hiding this comment.
Any reason not to use count_bytes here instead? It'd be ideal not to assume UTF-8 here by calling to_str()
There was a problem hiding this comment.
Agreed - not only are C strings not necessarily UTF8, the validation done by to_str is annoyingly expensive.
There was a problem hiding this comment.
yeah - I just re-surrected this from an old commit without looking at it
bugadani
reviewed
Jan 6, 2025
Dominaezzz
reviewed
Jan 6, 2025
Dominaezzz
reviewed
Jan 6, 2025
Dominaezzz
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…nction
Thank you for your contribution!
We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:
Submission Checklist 📝
cargo xtask fmt-packagescommand to ensure that all changed code is formatted correctly.CHANGELOG.mdin the proper section.Extra:
Pull Request Details 📖
Description
atoiandstrdupROM-functions with our own implementation (to fix WPA2-ENTERPRISE functionality)memchrROM-function for ESP32, ESP32-C3 and ESP32-H2 (to fix the issue in Update dependencies foresp-hal,esp-wifiandembassy-netesp-mbedtls#62)skip-changelogb.c. of the changes inesp-halTesting
WPA2-ENTERPRISE example (have it locally - can provide if needed)