-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove nb crate #2882
Draft
SergioGasquez
wants to merge
24
commits into
esp-rs:main
Choose a base branch
from
SergioGasquez:feat/remove-nb
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Remove nb crate #2882
+66
−172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SergioGasquez
force-pushed
the
feat/remove-nb
branch
2 times, most recently
from
January 3, 2025 14:15
c0e99a3
to
34ea519
Compare
jessebraham
reviewed
Jan 3, 2025
SergioGasquez
force-pushed
the
feat/remove-nb
branch
3 times, most recently
from
January 3, 2025 15:26
6cf562b
to
8bf7839
Compare
jessebraham
reviewed
Jan 6, 2025
bugadani
reviewed
Jan 6, 2025
SergioGasquez
force-pushed
the
feat/remove-nb
branch
from
January 7, 2025 10:53
8bf7839
to
149e7ac
Compare
SergioGasquez
commented
Jan 8, 2025
SergioGasquez
commented
Jan 8, 2025
SergioGasquez
commented
Jan 8, 2025
bjoernQ
reviewed
Jan 8, 2025
SergioGasquez
force-pushed
the
feat/remove-nb
branch
4 times, most recently
from
January 9, 2025 11:20
211fe06
to
4652d56
Compare
…void using block!
SergioGasquez
force-pushed
the
feat/remove-nb
branch
from
January 9, 2025 13:58
4652d56
to
45d6e64
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for your contribution!
We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:
Submission Checklist 📝
cargo xtask fmt-packages
command to ensure that all changed code is formatted correctly.CHANGELOG.md
in the proper section.Extra:
Pull Request Details 📖
Description
This PR modifies spi/uart/timer to remove some nb::Results and embedded-hal-nb stuff.
read_byte
/write_byte
are now blocking for uart and spi.read_bytes
/write_bytes
return how many bytes they read/wrote.Testing
Describe how you tested your changes.
Closes #2729
Closes #2730