Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use _CONFIG_ to separate config prefix and key #2848

Merged
merged 3 commits into from
Jan 3, 2025
Merged

Conversation

bugadani
Copy link
Contributor

A lazy attempt to resolve #2846

@bugadani bugadani force-pushed the prefix branch 4 times, most recently from 65afc4b to 04edbe8 Compare December 20, 2024 09:16
@bugadani bugadani marked this pull request as ready for review December 20, 2024 11:18
@bugadani bugadani force-pushed the prefix branch 2 times, most recently from 09f77b3 to 6a00c53 Compare December 20, 2024 15:26
Copy link
Contributor

@bjoernQ bjoernQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bugadani bugadani changed the title Use two underscores to separate prefix Use _CONFIG_ to separate config prefix and key Dec 20, 2024
Copy link
Member

@SergioGasquez SergioGasquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@MabezDev MabezDev enabled auto-merge January 3, 2025 14:15
@MabezDev MabezDev added this pull request to the merge queue Jan 3, 2025
Merged via the queue into esp-rs:main with commit 337b3cc Jan 3, 2025
28 checks passed
@bugadani bugadani deleted the prefix branch January 3, 2025 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

esp-config cannot be used with esp-hal-embassy
5 participants