Change debug! to trace! to reduce logging noise
#2284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jessebraham
approved these changes
Oct 7, 2024
bugadani
reviewed
Oct 7, 2024
| @@ -65,18 +68,18 @@ pub fn compat_timer_arm_us(ets_timer: *mut ets_timer, us: u32, repeat: bool) { | |||
| timer.active = true; | |||
| timer.periodic = repeat; | |||
| } else { | |||
| debug!("timer_arm_us {:x} not found", ets_timer as usize); | |||
| trace!("timer_arm_us {:x} not found", ets_timer as usize); | |||
There was a problem hiding this comment.
This probably should remain at a higher level
There was a problem hiding this comment.
these are all quite frequent (with BLE at least) currently while things work fine -maybe they should be kept as debug and investigated
There was a problem hiding this comment.
I guess it's fine if they call disarm or done on a timer we don't know (yet) about
I'm not too sure if it's the same for arm? In theory if they never did setfn we cannot/don't need to do much - or maybe we should just initialize the timer in arm anyway with a no-op callback
There was a problem hiding this comment.
Yeah maybe if these timers are statically allocated...
| timer.active = false; | ||
| } else { | ||
| debug!("timer_disarm {:x} not found", ets_timer as usize); | ||
| trace!("timer_disarm {:x} not found", ets_timer as usize); |
| timer.active = false; | ||
|
|
||
| (*ets_timer).priv_ = core::ptr::null_mut(); | ||
| (*ets_timer).expire = 0; | ||
|
|
||
| TIMERS.swap_remove(idx); | ||
| } else { | ||
| debug!("timer_done {:x} not found", ets_timer as usize); | ||
| trace!("timer_done {:x} not found", ets_timer as usize); |
bugadani
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for your contribution!
We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:
Submission Checklist 📝
cargo xtask fmt-packagescommand to ensure that all changed code is formatted correctly.CHANGELOG.mdin the proper section.Extra:
Pull Request Details 📖
Description
Fixes #2282 - most of these are just noise and irrelevant for users
This doesn't deserve a changelog entry
Testing
Examples still work