add Rtc::disable_rom_message_printing #2280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimpolo
force-pushed
the
disable-rom-print
branch
from
f4f8f50 to
5acade1
Compare
dimpolo
force-pushed
the
disable-rom-print
branch
from
5acade1 to
8d7434d
Compare
jessebraham
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add method to temporarily disable log messages of the ROM bootloader on the S3 and H2.
I also checked the other chips but they don't document this functionality.
Corresponding TRM chapters:
Testing
Tested on the S3.
When using espflash with --monitor flag the first thing you'll see after flashing are the messages of the ROM bootloader.
After adding this method to a test program these messages disappear when re-flashing.