fix aero forcing for HIST in echam.yaml #1152
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nwieters
reviewed
Apr 11, 2024
Comment on lines
+414
to
+416
| #aerocoarse: histaerocoarse | ||
| #aerofarir: histaerofarir | ||
| #aerofin: histaerofin |
There was a problem hiding this comment.
Can these lines be removed?
There was a problem hiding this comment.
Yes, these lines can be removed
couplings/fesom/env_fesom.py
Outdated
| @@ -15,7 +15,7 @@ def prepare_environment(config): | |||
| "EXP_ID": config["general"]["command_line_config"]["expid"], | |||
| "iter_coup_regrid_method_ice2oce": "INTERPOLATE", | |||
| "fesom_use_icebergs": config["fesom"].get("use_icebergs", ""), | |||
| "BASIN_FILE": config["fesom"].get("basin_file"), | |||
| #"BASIN_FILE": config["fesom"].get("basin_file"), | |||
There was a problem hiding this comment.
Can this line be removed?
There was a problem hiding this comment.
Yes, this line can be removed. I made some more clean up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The aero forcing for the HIST scenario in echam.yaml was linked to the PI forcing. This gave me this error in the second year of simulation:
FATAL ERROR in aero_read_opt: file aero_coarse_1852.nc does not existAfter changing the echam.yaml to
the file is found and no error arises.
The rest is only clean up in the PISM coupling scripts