484 error handeling in case of empty yaml block

[nwieters]

Closes #484

[nwieters]

If there is an empty component in the user runscript:
amip:
or
amip: ""
the entry for this components in the user_config dictionary will be set to an empty dictionary.
user_config[model] = {}

and a user_note will be displayed to stdout:

Warning: YAML syntax
--------------------
The component amip in your configuration file /work/ab0995/a270089/runtime/awicm3-v3.1/run_issue_484_001/scripts/awicm3-v3.1-levante-TCO95L91-CORE2_initial_issue_484.yaml is empty. No further variables are set for this component in your runscript.

[nwieters]

Is there a way to prevent the user_note to be displayed twice?
I tried isinteractive but this is not available there.

Besides setting user_config[model] = {} I though about removing it from user_config:
del user_config[model]

What do you think is the better option?

[pgierz]

Looks good! Can go in :-)

[pgierz]

Is there a way to prevent the user_note to be displayed twice? I tried isinteractive but this is not available there.

You would need to cache all the warnings and notes and dump them all at the same time to cleanly do that. Don't build that.

Besides setting user_config[model] = {} I though about removing it from user_config: del user_config[model]

What do you think is the better option?

I would rather throw it away. Then we at least get KerError instead of something else that goes bad down the chain.

[nwieters]

Thank you @pgierz .

I now remove the empty components from user_config.

This is done before all other config files are merged in.
If you set for example:
oasis3mct:
in the runscript, it will be removed before the oasis configuration will be merged to user_config.

[mandresm]

It works well, and I'm okay with having a duplication here. I was looking at the code changes that would be needed to avoid the duplication of the warning and I don't think they are worth the time. Ideally this warning will be there for brief time, then people will fix their yaml files and then they won't need to see the double warning anymore.

[mandresm]

#bump