Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark mode #712

Closed
wants to merge 12 commits into from
Closed

Conversation

bstrdsmkr
Copy link

Description

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Local Pre-commit Checks
  • CI/CD Build

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • If applicable - I have commented my code, particularly in hard-to-understand areas
  • If applicable - I have made corresponding changes to the documentation
  • If applicable - I have added tests that prove my fix is effective or that my feature works
  • If applicable - New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

downiec and others added 11 commits January 10, 2025 08:48
…ocal_config, contains the configuration used when running Metagrid locally. Updated the manage_metagrid script to run Metagrid from the single docker-compose file. Updated some settings to use llnl instead of ornl for local development and testing. Removed some unused environment variable files after after testing that they aren't used. Left the default variables in place because Metagrid fails to build when several of the defaults aren't set, still working to troubeshoot why. Globus transfer steps in the front-end are working, however transfers seem to fail and need to be resolved.
* Switch from CRA to Vite and clean up tests

* Fixed issue with loading screen continuing even after cancel button click. Updated local test config. Globus transfers still not working.

---------

Co-authored-by: Zach Price <[email protected]>
Co-authored-by: downiec <[email protected]>
Auto generate configuration documentation with pre-commit hooks
…uns correctly. Removed the GLOBUS_REDIRECT setting and did some cleanup of the manage_metagrid.sh functions.
…are deprecated. Cleaned up and fixed some failing tests.
@bstrdsmkr bstrdsmkr force-pushed the dark-mode branch 2 times, most recently from 79df1bb to 5c1a7c4 Compare January 15, 2025 13:08
@downiec downiec deleted the branch esgf2-us:staticbuild-v1.3-fixes January 16, 2025 19:51
@downiec downiec closed this Jan 16, 2025
@sashakames
Copy link
Collaborator

Was this closed by accident?

@sashakames
Copy link
Collaborator

?

@sashakames
Copy link
Collaborator

I see if you delete the base branch it nullifies the PR, sorry @bstrdsmkr I think you can reopen, but select v1.3-release as the base for the PR,

@sashakames
Copy link
Collaborator

In the future its a better practice to reassign existing PRs to a new base branch before we delete the target.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants