Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Licensing module #48

Merged
merged 2 commits into from
Apr 10, 2024
Merged

Licensing module #48

merged 2 commits into from
Apr 10, 2024

Conversation

LourensVeen
Copy link
Collaborator

This fixes #37 and numbers the sections according to #47

@LourensVeen
Copy link
Collaborator Author

It seems to have built something and put it on GitHub Pages, but did that end up anywhere? Is there anyway I can see what this looks like?

@JaroCamphuijsen
Copy link
Collaborator

JaroCamphuijsen commented Apr 10, 2024

Hi @LourensVeen,
I am sorry for the incomplete documentation and quirky workflow. It will currently build on every push and put in on the gh-pages website but it will take the content from the main branch.

To check whether it build correctly you can change the config.json file, change the following line

"repoTag": "main",

to point to your branch: "repoTag": "licensing-module",

it will then build and deploy your content changes to the gh-pages website, however as soon as someone else pushes something it will trigger another deploy.

I'm working on documentation to build it locally, but based on the changes you made I actually think it will be fine. In the current development state of the project, I am happy to merge it as is.

Copy link
Collaborator

@JaroCamphuijsen JaroCamphuijsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like it works and it builds locally for me.

@JaroCamphuijsen JaroCamphuijsen merged commit 6bf0cc5 into main Apr 10, 2024
2 checks passed
@JaroCamphuijsen JaroCamphuijsen deleted the licensing-module branch April 10, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

licenses module: missing slides
2 participants