-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates to the research software module #120
Conversation
…ss instead of center tag
@DaniBodor this is the branch I created to make changes to the research software module. Feel free to put your changes in here as well. I was thinking that it might be a good idea to move the slide with the online code editor/compiler to an exercise instead because I still think it might be nice to let them fiddle a bit with some actual code, just to get the feeling of how this works if they have never done such a thing. What do you think? |
I think it is indeed nice for those who have never touched code before. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I cannot officially approve, because I started this PR, but I really approve of your changes @DaniBodor. Thank you for your thorough work. I think the quality of this module increased a lot because of your changes.
@@ -108,13 +101,11 @@ These punchcards would be loaded into the computer to instruct which parts of th | |||
|
|||
=== | |||
|
|||
<!-- .slide: data-state="standard" --> | |||
<!-- .slide: data-state="standard center" --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might want to consider, removing this slide with the unsplash image altogether because we have the VS code screenshot in the next slide. I think that is way better and having both seems a bit redundant.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed.
I updated this part a little bit in bf95ea3. Is it better like this, or do you think we should leave this slide out altogether?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, this is great!
No description provided.