Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strict option to fix #174. #321

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wbyoung
Copy link
Contributor

@wbyoung wbyoung commented Nov 9, 2014

This is a backwards-compatible fix for #174 that would probably be preferable over #320. It requires passing options to, exports({ strict: true }) to ensure no conflicting methods get added to lodash / underscore.

I think this seems like a good way of handling things, and the strict option could be documented such that it will always maintain compatibility with any enhancements added to lodash / underscore. For instance, if count was added to either, underscore.string would be updated to not export it (possibly causing some applications to require updates).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant