Fixing SNOPT not communicating the number of function evaluations to pagmo #25 #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on evaluations to the pagmo::problem it is optimizing. Changed the in and made the required changes for it to work. Added a check on the test that makes sure it works.
…f function evaluations to the pagmo::problem it is optimizing. Changed the in and made the required changes for it to work. Added a check on the test that makes sure it works." This reverts commit 9cd9161.
…on evaluations to the pagmo::problem it is optimizing. Changed the in and made the required changes for it to work. Added a check on the test that makes sure it works.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to fix #25, implementing @darioizzo's suggestion.
Added a test check, to make sure that the number of function evaluations shown by the UDP reflects the function evaluations made by SNOPT + the ones due to generating the population.
The modified test did not pass without the changes, but passed afterwards.
I tried to run the Python test as well, but could not figure out how to do it. If you deem it necessary and can give me some guidance on how to run it, I can do it and include the test instance to check for whether the number of function evaluations is correct.
Cheers!