Chrono migration #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you solve the conflicts and push? @cantordust ? |
|
I resolved the conflicts, but the CI actions are failing... |
class epoch =========== - Added a default constructor and a constructor for microseconds - Added constructor templates to resolve ambiguities - Fixed serialisation issues - Other fixes, cleanup
- Removed missing header included in planet_test.cpp
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6 +/- ##
==========================================
- Coverage 98.59% 98.46% -0.13%
==========================================
Files 21 20 -1
Lines 1206 1174 -32
==========================================
- Hits 1189 1156 -33
- Misses 17 18 +1
|
- Added typename to template
- Reordered initialisation in constructors of keplerian planet - Removed user-defined epoch::operator=() - Removed erroneous #include <bits/chrono.h>
… OSX and MSVC compilers
NOTE ==== epoch::julian_type is an enum *class* (not a plain enum). This is necessary to avoid implicit conversion from julian_type to an integral type.
- Formatting - Deprecated methods removed - Documentation updated TODO ==== - More verbose documentation - Improve test coverage
- Epoch now has a constructor epoch(y, mon, d, h, min, s, ms, us) - Improvements in printing (Clang shouldn't complain about thread safety) TODO ==== - Still no conversion from string. That would probably happen at the Python end in a static function, which would parse the string and then use the decoposed datetime object with the new constructor above.
- Reverted unsigned int arguments to int in one of the epoch constructors and epoch::make_tp()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently implemented:
TODO
mjd(),jd()andmjd2000()conversion functionsdouble